[llvm-bugs] [Bug 47354] New: missing code for llvm::emitStrNLen declaration

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=47354

            Bug ID: 47354
           Summary: missing code for llvm::emitStrNLen declaration
           Product: libraries
           Version: 10.0
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Transformation Utilities
          Assignee: unassignedbugs at nondot.org
          Reporter: yyc1992 at gmail.com
                CC: llvm-bugs at lists.llvm.org

This public API was added in
https://github.com/llvm/llvm-project/commit/7ba5b98720e020a628f3f1c11e924b384b7883b3
and the code for it was removed in
https://github.com/llvm/llvm-project/commit/455ea11d13a1f88d8c5c65f78ef21a81efab8f22.
The reason for the removal appears to be "dead code" although it is unclear how
can a public API be determined to be dead code.

I do think the correct fix here is to add back the definition though I'd like
to ask first if there's any deeper reasons behind the removal. Apparently no
one is using it since no one appears to have complained so far... In any case,
even if the function is to be removed the declaration should be removed as
well.

I noticed this when working on a ABI compatible backport for
https://reviews.llvm.org/D86837. The compatibility wrapper functions I generate
from the header causes a linker error due to missing function...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200829/75d905ad/attachment.html>