[llvm-bugs] [Bug 40859] New: Tidy up llvm-objcopy error messages

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Feb 26 02:13:30 PST 2019


https://bugs.llvm.org/show_bug.cgi?id=40859

            Bug ID: 40859
           Summary: Tidy up llvm-objcopy error messages
           Product: tools
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: llvm-objcopy
          Assignee: unassignedbugs at nondot.org
          Reporter: jh7370.2008 at my.bristol.ac.uk
                CC: alexander.v.shaposhnikov at gmail.com,
                    jake.h.ehrlich at gmail.com,
                    jh7370.2008 at my.bristol.ac.uk,
                    llvm-bugs at lists.llvm.org, rupprecht at google.com

We are a bit inconsistent in our error messages in llvm-objcopy. Some examples
that I know of:
1) Some end in trailing full stops. Others don't. I think the norm outside the
to is to not have full stops, but I don't really mind which it is, as long as
it is consistent.
2) Symbol names are sometimes quoted and other times not. Section names are
never quoted. I think we should adopt a consistent quoting scheme for both and
always use it. Both section and symbol names can theoretically contain spaces
(especially if we choose to start printing demangled symbol names at a later
point). I'd recommend something like single quotes for symbol names and double
quotes for section names, but I'm open to other schemes.
3) Don't know what the state of this one is, but capitalization of the first
word in the error message should be identical throughout. I think lower-case is
more normal outside the tool, but I'm not sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190226/db642eed/attachment.html>


More information about the llvm-bugs mailing list