[llvm-bugs] [Bug 35385] WASM backend generates invalid wasm for undeclared imports

via llvm-bugs llvm-bugs at lists.llvm.org
Wed Nov 29 17:33:13 PST 2017


https://bugs.llvm.org/show_bug.cgi?id=35385

jgravelle at google.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #9 from jgravelle at google.com ---
My point is more that it doesn't really fix this bug at all. It just changes us
from failure to build a valid wasm object file, to failure to link
independently-valid-but-disagreeing wasm object files.

It also breaks EM_ASM in C
(https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.wasm.llvm%2Flinux%2F26661%2F%2B%2Frecipes%2Fsteps%2FExecute_emscripten_testsuite__emwasm_%2F0%2Fstdout),
which long-term I don't really mind because it's using a pretty fragile
mechanism (i.e. prototypeless C function declarations, that are not even
well-defined because they are expected to have mismatching callsites).
Short-term it might be good to revert this until we can get EM_ASM not relying
on that behavior (which I have some ideas around solving once and for all).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20171130/2037df91/attachment.html>


More information about the llvm-bugs mailing list