<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:jgravelle@google.com" title="jgravelle@google.com">jgravelle@google.com</a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - WASM backend generates invalid wasm for undeclared imports"
href="https://bugs.llvm.org/show_bug.cgi?id=35385">bug 35385</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>FIXED
</td>
<td>---
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>REOPENED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - WASM backend generates invalid wasm for undeclared imports"
href="https://bugs.llvm.org/show_bug.cgi?id=35385#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - WASM backend generates invalid wasm for undeclared imports"
href="https://bugs.llvm.org/show_bug.cgi?id=35385">bug 35385</a>
from <span class="vcard"><a class="email" href="mailto:jgravelle@google.com" title="jgravelle@google.com">jgravelle@google.com</a>
</span></b>
<pre>My point is more that it doesn't really fix this bug at all. It just changes us
from failure to build a valid wasm object file, to failure to link
independently-valid-but-disagreeing wasm object files.
It also breaks EM_ASM in C
(<a href="https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.wasm.llvm%2Flinux%2F26661%2F%2B%2Frecipes%2Fsteps%2FExecute_emscripten_testsuite__emwasm_%2F0%2Fstdout">https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.wasm.llvm%2Flinux%2F26661%2F%2B%2Frecipes%2Fsteps%2FExecute_emscripten_testsuite__emwasm_%2F0%2Fstdout</a>),
which long-term I don't really mind because it's using a pretty fragile
mechanism (i.e. prototypeless C function declarations, that are not even
well-defined because they are expected to have mismatching callsites).
Short-term it might be good to revert this until we can get EM_ASM not relying
on that behavior (which I have some ideas around solving once and for all).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>