[llvm-bugs] [Bug 31187] wrong code with "opt -loop-rotate -licm -loop-unroll"

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Feb 21 11:13:32 PST 2017


https://bugs.llvm.org/show_bug.cgi?id=31187

Hans Wennborg <hans at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Hans Wennborg <hans at chromium.org> ---
(In reply to Chandler Carruth from comment #9)
> (In reply to Hans Wennborg from comment #7)
> > Chandler, do you know what would cause the test case to assert when your
> > patch is merged to 4.0?
> 
> Yes, the issue is that you're adding testing for LICM in the new PM which
> hits several asserts specific to the new PM.
> 
> To make this test reasonable I think you'd need at least r292241 and
> r292709, but this is well outside of "safe" patches to port and I don't know
> how many others would be needed.
> 
> I think you should just drop the test from the branch -- the new PM's loop
> pass support just isn't complete enough for it to make sense to test heavily
> or expect to work well when tested.

Thanks! Merged without the test in r295748.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20170221/23258386/attachment.html>


More information about the llvm-bugs mailing list