<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:hans@chromium.org" title="Hans Wennborg <hans@chromium.org>"> <span class="fn">Hans Wennborg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - wrong code with "opt -loop-rotate -licm -loop-unroll""
href="https://bugs.llvm.org/show_bug.cgi?id=31187">bug 31187</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - wrong code with "opt -loop-rotate -licm -loop-unroll""
href="https://bugs.llvm.org/show_bug.cgi?id=31187#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - wrong code with "opt -loop-rotate -licm -loop-unroll""
href="https://bugs.llvm.org/show_bug.cgi?id=31187">bug 31187</a>
from <span class="vcard"><a class="email" href="mailto:hans@chromium.org" title="Hans Wennborg <hans@chromium.org>"> <span class="fn">Hans Wennborg</span></a>
</span></b>
<pre>(In reply to Chandler Carruth from <a href="show_bug.cgi?id=31187#c9">comment #9</a>)
<span class="quote">> (In reply to Hans Wennborg from <a href="show_bug.cgi?id=31187#c7">comment #7</a>)
> > Chandler, do you know what would cause the test case to assert when your
> > patch is merged to 4.0?
>
> Yes, the issue is that you're adding testing for LICM in the new PM which
> hits several asserts specific to the new PM.
>
> To make this test reasonable I think you'd need at least r292241 and
> r292709, but this is well outside of "safe" patches to port and I don't know
> how many others would be needed.
>
> I think you should just drop the test from the branch -- the new PM's loop
> pass support just isn't complete enough for it to make sense to test heavily
> or expect to work well when tested.</span >
Thanks! Merged without the test in r295748.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>