[LLVMbugs] [Bug 16132] Uninitialized read in ARMDisassembler

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=16132

Benjamin Kramer <benny.kra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |benny.kra at gmail.com
         Resolution|---                         |FIXED

--- Comment #3 from Benjamin Kramer <benny.kra at gmail.com> ---
(In reply to comment #2)
> Created attachment 10577 [details]
> Proposed fix
> 
> This makes the report disappear, but may not fix the real cause.
> 
> Gdb shows that Region.readBytes(Address, 4, ... is called on a 92-byte
> buffer at offset 90.

The underlying implementation of Region started accepting out of bounds reads
by just returning a subset of the queried bytes. Your would be the right fix
for this instance, but there are many calls in all of the disassemblers that
get this wrong. I went ahead and removed the out parameter, standardizing on
the behavior the code expects in r182636.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20130524/bf4e4e10/attachment.html>