<html>
<head>
<base href="http://llvm.org/bugs/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:benny.kra@gmail.com" title="Benjamin Kramer <benny.kra@gmail.com>"> <span class="fn">Benjamin Kramer</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Uninitialized read in ARMDisassembler"
href="http://llvm.org/bugs/show_bug.cgi?id=16132">bug 16132</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>ASSIGNED
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>benny.kra@gmail.com
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Uninitialized read in ARMDisassembler"
href="http://llvm.org/bugs/show_bug.cgi?id=16132#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Uninitialized read in ARMDisassembler"
href="http://llvm.org/bugs/show_bug.cgi?id=16132">bug 16132</a>
from <span class="vcard"><a class="email" href="mailto:benny.kra@gmail.com" title="Benjamin Kramer <benny.kra@gmail.com>"> <span class="fn">Benjamin Kramer</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=16132#c2">comment #2</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=10577" name="attach_10577" title="Proposed fix">attachment 10577</a> <a href="attachment.cgi?id=10577&action=edit" title="Proposed fix">[details]</a></span>
> Proposed fix
>
> This makes the report disappear, but may not fix the real cause.
>
> Gdb shows that Region.readBytes(Address, 4, ... is called on a 92-byte
> buffer at offset 90.</span >
The underlying implementation of Region started accepting out of bounds reads
by just returning a subset of the queried bytes. Your would be the right fix
for this instance, but there are many calls in all of the disassemblers that
get this wrong. I went ahead and removed the out parameter, standardizing on
the behavior the code expects in r182636.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>