[LLVMbugs] [PATCH] dumbify tblgen

Chris Lattner sabre at nondot.org
Mon Jul 12 23:26:19 PDT 2004

On Tue, 13 Jul 2004, Vladimir Prus wrote:

> Chris Lattner wrote:
> > On Mon, 12 Jul 2004, Vladimir Prus wrote:
> > > the attached patch removes, per IRC discussion, the smart behaviour of
> > > tblgen, which does not update output files if content did not change --
> > > which confuses build tools.
> >
> > This patch will work, but I would prefer it if tblgen didn't write to a
> > temporary file at all.  Instead of opening "foo.tmp" to begin with, it
> > should just write to "foo" directly.
> I though about it, but decided to still write to temporary file, so the the
> output is not altered when there's something wrong with the input. Not
> exactly sure why I wanted this -- build system will remove output if tblgen
> fails anyway. New patch attached.

Applied, thanks!

> BTW, my Emacs says TableGen.cpp has tabs. What to do about this? I guess
> your coding standard suggests indentenation with spaces, no?

Tabs sneak in occasionally, but if should always be removed if you run
into them.  Patches are very appreciated if you hit any. :)



More information about the llvm-bugs mailing list