[LLVMbugs] [PATCH] dumbify tblgen

Vladimir Prus ghost at cs.msu.su
Mon Jul 12 23:04:47 PDT 2004


Chris Lattner wrote:
> On Mon, 12 Jul 2004, Vladimir Prus wrote:
> > the attached patch removes, per IRC discussion, the smart behaviour of
> > tblgen, which does not update output files if content did not change --
> > which confuses build tools.
>
> This patch will work, but I would prefer it if tblgen didn't write to a
> temporary file at all.  Instead of opening "foo.tmp" to begin with, it
> should just write to "foo" directly.

I though about it, but decided to still write to temporary file, so the the 
output is not altered when there's something wrong with the input. Not 
exactly sure why I wanted this -- build system will remove output if tblgen 
fails anyway. New patch attached.

BTW, my Emacs says TableGen.cpp has tabs. What to do about this? I guess your 
coding standard suggests indentenation with spaces, no?

- Volodya
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TableGen.diff
Type: text/x-diff
Size: 1660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20040713/d1be2c2c/attachment.diff>


More information about the llvm-bugs mailing list