[llvm-branch-commits] [llvm] release/18.x: [Release] Don't build during test-release.sh Phase 3 install (#82001) (PR #82420)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Feb 20 13:17:56 PST 2024


https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/82420

Backport f6ac598c104ed3c9f4bcbbe830f86500c8d1013e

Requested by: @rorth

>From 98228d4cdb8e933be66b3a5cd08992366b31fb1d Mon Sep 17 00:00:00 2001
From: Rainer Orth <ro at gcc.gnu.org>
Date: Tue, 20 Feb 2024 07:26:48 +0100
Subject: [PATCH] [Release] Don't build during test-release.sh Phase 3 install
 (#82001)

As described in [test-release.sh ninja install does builds in Phase
3](https://github.com/llvm/llvm-project/issues/80999), considerable
parts of Phase 3 of a `test-release.sh` build are run by `ninja
install`, ignoring both `$Verbose` and the parallelism set via `-j NUM`.

This patches fixes this by not specifying any explicit build target for
Phase 3, thus running the full build as usual.

Tested on `sparc64-unknown-linux-gnu`.

(cherry picked from commit f6ac598c104ed3c9f4bcbbe830f86500c8d1013e)
---
 llvm/utils/release/test-release.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/llvm/utils/release/test-release.sh b/llvm/utils/release/test-release.sh
index 5b1945df47d24a..0af16387ce1d8e 100755
--- a/llvm/utils/release/test-release.sh
+++ b/llvm/utils/release/test-release.sh
@@ -537,6 +537,11 @@ function build_llvmCore() {
         InstallTarget="$InstallTarget install-runtimes"
       fi
     fi
+    if [ "$Phase" -eq "3" ]; then
+      # Build everything at once, with the proper parallelism and verbosity,
+      # in Phase 3.
+      BuildTarget=
+    fi
 
     cd $ObjDir
     echo "# Compiling llvm $Release-$RC $Flavor"



More information about the llvm-branch-commits mailing list