[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

Fangrui Song via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Feb 15 00:17:05 PST 2024


================
@@ -1279,9 +1278,6 @@ bool AddressSanitizer::isInterestingAlloca(const AllocaInst &AI) {
       (AI.getAllocatedType()->isSized() &&
----------------
MaskRay wrote:

In `ClInstrumentUninterestingAllocas=0 mode`, `!(SSGI && SSGI->isSafe(AI))` can ignore some `AllocaInst`s that `SSGI->stackAccessIsSafe(*Inst)` will return false.

My original thought is that `ClInstrumentUninterestingAllocas` isn't useful and we should just remove it.

If you think `ClInstrumentUninterestingAllocas` is unnecessary, I will remove it.

https://github.com/llvm/llvm-project/pull/77221


More information about the llvm-branch-commits mailing list