[llvm-branch-commits] [compiler-rt] release/18.x: [compiler-rt][profile] Fix InstrProfilingFile possible resource leak. (#81363) (PR #81402)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sun Feb 11 00:25:57 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-pgo

Author: None (llvmbot)

<details>
<summary>Changes</summary>

Backport 0a255fcf4a90f9e864ae9321b28e4956f7c865fb

Requested by: @<!-- -->devnexen

---
Full diff: https://github.com/llvm/llvm-project/pull/81402.diff


1 Files Affected:

- (modified) compiler-rt/lib/profile/InstrProfilingFile.c (+3) 


``````````diff
diff --git a/compiler-rt/lib/profile/InstrProfilingFile.c b/compiler-rt/lib/profile/InstrProfilingFile.c
index 867ae73f0d3b27..f3b457d786e6bd 100644
--- a/compiler-rt/lib/profile/InstrProfilingFile.c
+++ b/compiler-rt/lib/profile/InstrProfilingFile.c
@@ -677,6 +677,7 @@ static void initializeProfileForContinuousMode(void) {
       PROF_ERR("Continuous counter sync mode is enabled, but raw profile is not"
                "page-aligned. CurrentFileOffset = %" PRIu64 ", pagesz = %u.\n",
                (uint64_t)CurrentFileOffset, PageSize);
+      fclose(File);
       return;
     }
     if (writeProfileWithFileObject(Filename, File) != 0) {
@@ -692,6 +693,8 @@ static void initializeProfileForContinuousMode(void) {
 
   if (doMerging()) {
     lprofUnlockFileHandle(File);
+  }
+  if (File != NULL) {
     fclose(File);
   }
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/81402


More information about the llvm-branch-commits mailing list