[llvm-branch-commits] [llvm] cb37105 - Revert "[TableGen] Ignore inaccessible memory when checking pattern flags (#9…"

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Apr 26 06:47:19 PDT 2024


Author: Jay Foad
Date: 2024-04-26T14:47:16+01:00
New Revision: cb37105c23926b07488c2f0a9a603634d9be4936

URL: https://github.com/llvm/llvm-project/commit/cb37105c23926b07488c2f0a9a603634d9be4936
DIFF: https://github.com/llvm/llvm-project/commit/cb37105c23926b07488c2f0a9a603634d9be4936.diff

LOG: Revert "[TableGen] Ignore inaccessible memory when checking pattern flags (#9…"

This reverts commit 6578356a4e3e6acd7983c74feab43ac96925894c.

Added: 
    

Modified: 
    llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
index e0e31739e26262..88d353e89a4614 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
@@ -3616,15 +3616,7 @@ class InstAnalyzer {
       hasChain = true;
 
     if (const CodeGenIntrinsic *IntInfo = N.getIntrinsicInfo(CDP)) {
-      // Ignore reads/writes to inaccessible memory. These should not imply
-      // mayLoad/mayStore on the instruction because they are often used to
-      // model dependencies that Machine IR expresses as uses/defs of a
-      // special physical register.
-      ModRefInfo MR = ModRefInfo::NoModRef;
-      for (MemoryEffects::Location Loc : MemoryEffects::locations()) {
-        if (Loc != MemoryEffects::Location::InaccessibleMem)
-          MR |= IntInfo->ME.getModRef();
-      }
+      ModRefInfo MR = IntInfo->ME.getModRef();
       // If this is an intrinsic, analyze it.
       if (isRefSet(MR))
         mayLoad = true; // These may load memory.


        


More information about the llvm-branch-commits mailing list