[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

Andres Villegas via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Apr 23 15:13:28 PDT 2024


avillega wrote:

I was trying to figure out why llvm-dwarfdump does not seem to be affected by my change, there are note failing tests and I don't see any changes by doing some manual testing of some simple test cases. It seems that `llvm-dwarfdump` does not use the API I changed, for `--debug_lines` they use `DWARFDebugLine::SectionParser::parseNext` instead. However, it does affect `llvm-rdtyld` as exposed by the checks. I could ignore the `end_sequence` row when they are at the last position of the rows vector, for the users of `DWARFDebugLine::LineTable::lookupAddressRange`. Please let me know what do you think. Either way I will split the PR into dwarf api changes and gsym changes. 

https://github.com/llvm/llvm-project/pull/89703


More information about the llvm-branch-commits mailing list