[llvm-branch-commits] [llvm] [LAA] Support different strides & non constant dep distances using SCEV. (PR #88039)

Florian Hahn via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Apr 19 06:17:06 PDT 2024


fhahn wrote:

> > > I would enjoy more textual description of what every condition is meant to check.
> > 
> > 
> > There are multiple places that hand off reasoning to called functions, would you like to have a summary of what the function checks there? Could do as separate patch, as this would be independent of the current patch?
> 
> I was not familiar with this code, trying to reduce the impact of this patch doesn't help me to understand it and convince myself that it does not cause miscompilation, it rather makes it even more difficult since conditions are now all over the place.
> 

Thanks, I put up https://github.com/llvm/llvm-project/pull/89381 to add extra documentation and updated this PR to be based on #89381

https://github.com/llvm/llvm-project/pull/88039


More information about the llvm-branch-commits mailing list