[llvm-branch-commits] [lld] 02ccc2a - [lld][ELF][test] Fix excessive output file size in loongarch-add-sub.s

Tobias Hieta via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Jul 27 06:38:21 PDT 2023


Author: WANG Xuerui
Date: 2023-07-27T15:36:55+02:00
New Revision: 02ccc2a8fff1f63afbdfa81274549122d5e7d574

URL: https://github.com/llvm/llvm-project/commit/02ccc2a8fff1f63afbdfa81274549122d5e7d574
DIFF: https://github.com/llvm/llvm-project/commit/02ccc2a8fff1f63afbdfa81274549122d5e7d574.diff

LOG: [lld][ELF][test] Fix excessive output file size in loongarch-add-sub.s

Initially the .rodata section came before .text, hence sharing its
segment with the program header sitting at a small offset, pushing the
output file size to ~72GiB (the file was sparse though, so not much is
really written). This breaks on 32-bit platforms and is irrelevant to
the feature being tested, so re-order the two sections so .text gets
processed first, and both sections get their own segment.

This addresses the issue found by the clang-armv8-lld-2stage builder:
    https://lab.llvm.org/buildbot/#/builders/178/builds/5340

Reviewed By: SixWeining, xry111

Differential Revision: https://reviews.llvm.org/D156293

(cherry picked from commit ffe2b6f75de55b665520669059c3d95240482d54)

Added: 
    

Modified: 
    lld/test/ELF/loongarch-add-sub.s

Removed: 
    


################################################################################
diff  --git a/lld/test/ELF/loongarch-add-sub.s b/lld/test/ELF/loongarch-add-sub.s
index 963e4cbbe0fcd7..63a3f7de179e6b 100644
--- a/lld/test/ELF/loongarch-add-sub.s
+++ b/lld/test/ELF/loongarch-add-sub.s
@@ -2,14 +2,14 @@
 
 # RUN: llvm-mc --filetype=obj --triple=loongarch64-unknown-elf %s -o %t.la64.o
 
-# RUN: ld.lld --section-start=.rodata=0x1234567890 --section-start=.text=0x9876543210 %t.la64.o -o %t.la64
+# RUN: ld.lld --section-start=.text=0x1234567890 --section-start=.rodata=0x9876543210 %t.la64.o -o %t.la64
 # RUN: llvm-readelf -x .rodata %t.la64 | FileCheck --check-prefix=CHECK %s
 # CHECK:      section '.rodata':
-# CHECK-NEXT: 0x1234567890 10325476 98badcfe 80b9fd41 86000000
-# CHECK-NEXT: 0x12345678a0 80b9fd41 80b980
+# CHECK-NEXT: 0x9876543210 10325476 98badcfe 804602be 79ffffff
+# CHECK-NEXT: 0x9876543220 804602be 804680
 
+.text
 .global _start
-
 _start:
 1:
     break 0


        


More information about the llvm-branch-commits mailing list