[llvm-branch-commits] [llvm] abf3297 - [SCEV] Increase FoldID bits size cover common cases.

Tobias Hieta via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Feb 27 00:15:07 PST 2023


Author: Florian Hahn
Date: 2023-02-27T09:14:48+01:00
New Revision: abf32977809e8a04c9c98b9f3c72d43e37931ee9

URL: https://github.com/llvm/llvm-project/commit/abf32977809e8a04c9c98b9f3c72d43e37931ee9
DIFF: https://github.com/llvm/llvm-project/commit/abf32977809e8a04c9c98b9f3c72d43e37931ee9.diff

LOG: [SCEV] Increase FoldID bits size cover common cases.

This should fix the regressions introduced by a53d940cee6f by making
sure no dynamic allocations are needed in the common case, while
retaining support for arbitrary SCEV expressions.

Alternative to D144335.

Compile-time impact:
* NewPM-O3: -0.11%
* NewPM-ReleaseThinLTO: -0.10%
*NewPM-ReleaseLTO-g: -0.08%

https://llvm-compile-time-tracker.com/compare.php?from=df016a9525e5722dfd1e1e1632cec3ed7b33bc8a&to=c1c64de4a973bcecaddbc4038a539234eb39413b&stat=instructions:u

Reviewed By: vitalybuka, nikic

Differential Revision: https://reviews.llvm.org/D144382

(cherry picked from commit eddecd3ade5ce1b827dafb84e8137cc6f89576fb)

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/ScalarEvolution.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/ScalarEvolution.h b/llvm/include/llvm/Analysis/ScalarEvolution.h
index 57107cb8d367c..51b67d1756b9a 100644
--- a/llvm/include/llvm/Analysis/ScalarEvolution.h
+++ b/llvm/include/llvm/Analysis/ScalarEvolution.h
@@ -1297,7 +1297,7 @@ class ScalarEvolution {
   bool loopIsFiniteByAssumption(const Loop *L);
 
   class FoldID {
-    SmallVector<unsigned, 4> Bits;
+    SmallVector<unsigned, 5> Bits;
 
   public:
     void addInteger(unsigned long I) {


        


More information about the llvm-branch-commits mailing list