[llvm-branch-commits] [llvm] 87a8954 - [NFC] Minor cleanup for ValueHandle code.

Varun Gandhi via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Jan 20 16:33:08 PST 2021


Author: Varun Gandhi
Date: 2021-01-20T16:27:55-08:00
New Revision: 87a89549c4b14a5e19097484562dd359b77a8770

URL: https://github.com/llvm/llvm-project/commit/87a89549c4b14a5e19097484562dd359b77a8770
DIFF: https://github.com/llvm/llvm-project/commit/87a89549c4b14a5e19097484562dd359b77a8770.diff

LOG: [NFC] Minor cleanup for ValueHandle code.

Based on feedback in https://reviews.llvm.org/D93433.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D94238

Added: 
    

Modified: 
    llvm/include/llvm/IR/ValueHandle.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/IR/ValueHandle.h b/llvm/include/llvm/IR/ValueHandle.h
index a88b28ac7e62..29560815ea55 100644
--- a/llvm/include/llvm/IR/ValueHandle.h
+++ b/llvm/include/llvm/IR/ValueHandle.h
@@ -287,7 +287,7 @@ class AssertingVH
 #else
   AssertingVH() : ThePtr(nullptr) {}
   AssertingVH(ValueTy *P) : ThePtr(GetAsValue(P)) {}
-  AssertingVH(const AssertingVH<ValueTy> &) = default;
+  AssertingVH(const AssertingVH &) = default;
 #endif
 
   operator ValueTy*() const {
@@ -442,9 +442,9 @@ class CallbackVH : public ValueHandleBase {
 /// PoisoningVH's as it moves. This is required because in non-assert mode this
 /// class turns into a trivial wrapper around a pointer.
 template <typename ValueTy>
-class PoisoningVH
+class PoisoningVH final
 #if LLVM_ENABLE_ABI_BREAKING_CHECKS
-    final : public CallbackVH
+    : public CallbackVH
 #endif
 {
   friend struct DenseMapInfo<PoisoningVH<ValueTy>>;


        


More information about the llvm-branch-commits mailing list