[lldb-dev] Help with MSVC build issues

Eugene Zelenko via lldb-dev lldb-dev at lists.llvm.org
Thu Oct 22 10:08:05 PDT 2015

Hi, Zachary!

On Thu, Oct 22, 2015 at 9:34 AM, Zachary Turner <zturner at google.com> wrote:
> I'm taking a look now. In the future please revert changes that break a
> buildbot.  If you think you might know what the fix is (i.e. you guess that
> including a header will fix it), then you can just check it in as a test.
> If after a few attempts you still can't figure it out, then revert the
> change out again.
> But definitely please don't leave broken changes in.  For example, the MSVC
> buildbot is now failing due to changes in LLVM.  The reason is because it
> broke last night due to some unrelated changes which weren't reverted, and
> subsequent breaks did not result in an email to other people so they didn't
> know.  We need to avoid this situation, so the bot has to stay green.
> anyway I'm working on fixing it now

At first I want to apologize for broken builds.

In two previous cases were reason was more or less clear, I reverted
my changes after receiving buildbot notifications.

I was not sure about last case, since fix should be made in file which
I didn't change in previous commit.

Sure, I'll try to bu more careful in future.


More information about the lldb-dev mailing list