[lldb-dev] serialized, low-load test pass in parallel test runner
Todd Fiala via lldb-dev
lldb-dev at lists.llvm.org
Sat Nov 28 06:36:17 PST 2015
Thanks, Reid and Pavel!
On Fri, Nov 27, 2015 at 1:21 PM, Pavel Labath <labath at google.com> wrote:
> I think it sounds like something that would be useful in general. I'd
> even go a step further and say that we can replace the current flakey
> test mechanism with your proposed solution.
Okay, I like that idea.
> If we do that (remove the
> current flakey mechanism when this is in place), then I think it would
> be super-great as we don't increase the number of moving parts and we
> can think of this as just an upgrade of an inferior solution (the
> current flakey mechanism has always felt like a hack to me) with a
> better one.
> If you want to automatically re-run tests, then we can have a mode
> that does that, but I'd like to have it off by default. I have several
> reasons for this:
> - you get to feel bad for having to add flakey decorators, which may
> encourage you to fix things
> - if you make a change (hopefully only locally :) ) which breaks a lot
> of tests, you want this to fail quickly instead of waiting for reruns
> - if you make a change that makes things flakey (!), you may not
> actually notice it because of the reruns
I'm fine with that. The only caveat I see is that it appears we have a
largish number of potential-failing tests under high load, so we may end up
(at least on OS X) marking quite a few up this way. But, that's also
helpful since it lets us see which of the tests really are failing under
load. So this is all likely for the best, with a small ramp-up time to
while we "discover" which tests are hitting this.
> On 27 November 2015 at 18:58, Todd Fiala via lldb-dev
> <lldb-dev at lists.llvm.org> wrote:
> > Note this is similar to the flakey test mechanism, with the primary
> > difference being that the re-run is done in a minimal CPU load
> > rather than wherever the failure first occurred. The existing flakey
> > rerun logic is not helpful for the high-load-induced failures that I'm
> > looking to handle.
> > On Fri, Nov 27, 2015 at 10:56 AM, Todd Fiala <todd.fiala at gmail.com>
> >> Hi all,
> >> On OS X (and frankly on Linux sometimes as well, but predominently OS
> >> we have tests that will sometimes fail when under significant load (e.g.
> >> running the concurrent test suite, exacerbated if we crank up the
> number of
> >> threads, but bad enough if we run at "number of concurrent workers ==
> >> of logical cores").
> >> I'm planning on adding a serialized, one-worker-only phase to the end of
> >> the concurrent test run, where the load is much lighter since only one
> >> worker will be processing at that phase. Then, for tests that fail in
> >> first run, I'd re-run them in the serialized, single worker test run
> >> On the OS X side, this would eliminate a significant number of test
> >> that are both hard to diagnose and hard to justify spending significant
> >> amounts of time on in the short run. (There's a whole other
> conversation to
> >> have about fixing them for real, i.e. working through all the race
> >> faulty test logic assumptions that are stressed to the max under heavier
> >> load, but practically speaking, there are so many of them that this is
> >> to be impractical to address in the short/mid term.).
> >> My question to all of you is if we'd want this functionality in top of
> >> tree llvm.org lldb. If not, I'll do it in one of our branches. If
> so, we
> >> can talk about possibly having a category or some other mechanism if we
> >> to mark those tests that are eligible to be run in the follow-up
> >> low-load pass. Up front I was just going to allow any test to fall into
> >> that bucket. The one benefit to having it in top of tree llvm.org is
> >> once I enable test reporting on the green dragon public llvm.org OS X
> >> builder, that builder will be able to take advantage of this, and will
> >> certainly tag fewer changes as breaking a test (in the case where the
> >> is just one of the many that fail under high load).
> >> Let me know your thoughts either way.
> >> Thanks!
> >> --
> >> -Todd
> > --
> > -Todd
> > _______________________________________________
> > lldb-dev mailing list
> > lldb-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-dev