[lldb-dev] New test summary results formatter
Zachary Turner via lldb-dev
lldb-dev at lists.llvm.org
Wed Dec 2 21:48:26 PST 2015
On Wed, Dec 2, 2015 at 9:44 PM Todd Fiala <todd.fiala at gmail.com> wrote:
>> and the classname could be dropped (there's only one class per file
>> anyway, so the classname is just wasted space)
> Part of the reason I included that is I've hit several times where copy
> and paste errors lead to the same class name, method name or even file name
> being used for a test. I think, though, that most of those are addressed
> by having the path (relative is fine) to the python test file. I think we
> can probably get by with classname.methodname (relative test path). (From
> your other email, I think you nuke the classname and keep the module name,
> but I'd probably do the reverse, keeping the class name and getting rid of
> the module name since it can be derived from the filename).
I don't think the filename can be the same anymore, as things will break if
two filenames are the same. We could go one step further and enforce this
in the part where it scans for all the tests. If it finds two test files
with the same name we could just generate an error. I think that's a good
idea anyway, because if two test files have the same name, then the tests
inside must be similar enough to warrant merging them into the same file.
If no two filenames are the same, and if there's only 1 class per file,
then filename + method name should uniquely identify a single test, and so
you could omit the class name and show a relative path to the filename.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-dev