[lldb-dev] How to submit patches for reviev?

Todd Fiala tfiala at google.com
Wed Mar 12 08:31:08 PDT 2014


I don't think anybody would be offended if you pinged, but if you haven't
seen anything in two or three days, that seems fair to ping again.


On Wed, Mar 12, 2014 at 8:27 AM, Kuba Ober <kuba at mareimbrium.org> wrote:

> What’s, the, um, customary waiting period before I should somehow “ping”
> about the patch
> languishing (should it do so - it’s only been a day so far, so I’m not
> worried)?
>
> Thanks, Kuba
>
> On Mar 12, 2014, at 11:24 AM, Todd Fiala <tfiala at google.com> wrote:
> >
> > That's totally fine.  Usually I see people post patches to lldb-commits
> when they're fairly routine, or post the patch to lldb-dev when there might
> be a lot more discussion about it (i.e. more experimental or exploratory).
>  That's my take, anyway.
> >
> >> There’s some LLDB build breakage visible at least when generating ninja
> output, under OS X 10.9.
> >>
> >> I have posted a patch to lldb-commits. Is that the right thing to do?
> >> The webpage isn’t quite clear on that.
> >>
> >> Cheers, Kuba
>
>
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140312/1cc57cbb/attachment.html>


More information about the lldb-dev mailing list