[Lldb-commits] [lldb] [lldb] Fix type lookup in DWARF .o files via debug map (PR #87177)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Sun Mar 31 09:17:17 PDT 2024


================
@@ -1391,7 +1391,7 @@ void SymbolFileDWARFDebugMap::ParseDeclsForContext(
     lldb_private::CompilerDeclContext decl_ctx) {
   ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) -> bool {
     oso_dwarf->ParseDeclsForContext(decl_ctx);
-    return true; // Keep iterating
+    return false; // Keep iterating
----------------
Michael137 wrote:

Outside the scope of this patch, but note that `ParseDeclsForContext` isn't actually doing anything specific to the object file. Calling it multiple times for the same `decl_ctx` happens to be a no-op, but this doesn't feel like something that should be on `SymbolFile`.

https://github.com/llvm/llvm-project/pull/87177


More information about the lldb-commits mailing list