[Lldb-commits] [lldb] [lldb] Fix type lookup in DWARF .o files via debug map (PR #87177)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Sun Mar 31 09:11:43 PDT 2024


================
@@ -1233,7 +1233,7 @@ void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query,
   std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
   ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) -> bool {
     oso_dwarf->FindTypes(query, results);
-    return !results.Done(query); // Keep iterating if we aren't done.
+    return results.Done(query); // Keep iterating if we aren't done.
----------------
Michael137 wrote:

Outside the scope of this patch, but I think we should finally change the return type to an enum that makes it easier to figure out whether we want to "continue" versus "short-circuit".

https://github.com/llvm/llvm-project/pull/87177


More information about the lldb-commits mailing list