[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

Yeah, you're right.  And as I walk through in my head what I'm solving with this -- it's not the really expensive part of this whole operation, I don't think.  I should check more carefully but it's the stat's over NFS partitions that are impacting performance, and I doubt the realpath() to expand the tilde's is a significant factor (the kernel should cache all of these inodes anyway if we're doing it in a hot fashion).  I'll probably abandon this altogether unless I can prove to myself that it's important, and hoist it into the base class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125505/new/

https://reviews.llvm.org/D125505