[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

I don't think the cache belongs in a global in the TildeExpressionResolver class.  The derived ExpressionResolvers might very well resolve the same ~foo to different paths (e.g. if there were a RemoteTildeExpressionResolver.)  So the cache needs to be kept in the derived class rather than in a global object.  Maybe just add an abstract GetTildeCache method to TildeExpressionResolver to fetch the cache from the subclass?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125505/new/

https://reviews.llvm.org/D125505