[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

Ed Maste via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 13 09:45:37 PDT 2020


emaste added a comment.

Looks OK



================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449
+
+    assert(info.xsave_mask & XFEATURE_ENABLED_X87);
+    assert(info.xsave_mask & XFEATURE_ENABLED_SSE);
+
----------------
I wonder if these should be an error rather than assertion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89193/new/

https://reviews.llvm.org/D89193



More information about the lldb-commits mailing list