[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I assume this fixes some of the tests we have already, but it would be good to mention that in the description.



================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:479
+  case XSaveRegSet:
+    // TODO: can WriteRegisterSet() ever be called without ReadRegisterSet()?
+    assert(m_xsave.size() > 0);
----------------
mgorny wrote:
> @labath, is this a safe assumption to make? Generally, if `ReadRegisterSet()` is not called, `m_xsave` will be zero-sized.
Interesting question. I don't really have an answer to that. Somebody obviously should fill out `m_xsave` before calling this function, but maybe it doesn't have to be `ReadRegisterSet()`? What will happen if the client sends a `G` packet before reading any registers?

That said, I'm not particularly troubled by this assertion. I wouldn't be surprised if we already had code making that assumption without even realizing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89193/new/

https://reviews.llvm.org/D89193