[Lldb-commits] [lldb] a06c28d - Temporarily revert "[test] Exit with an error if no tests are run."

[Jordan Rupprecht via lldb-commits]

Thanks, that explains it! Namely this part:

if sys.platform.startswith('win32'):
    # llvm.org/pr22274: need a pexpect replacement for windows
    class PExpectTest(object):
        pass
else:
    import pexpect
    class PExpectTest(TestBase):

For this change to reland, I'll need to make it always inherit from
TestBase, but suppressed in some other way (maybe seeing if decorators
like @skipIfWindows can be applied to whole test classes)


On Mon, Aug 3, 2020 at 11:40 PM Raphael “Teemperor” Isemann <
teemperor at gmail.com> wrote:

> If it helps, all the failing tests are pexpect tests which are always
> disabled on Windows (like, they don't even exist from the test runners POV
> I believe). So I guess that's accidentially triggering that error.
>
> - Raphael
>
> > On 4 Aug 2020, at 03:39, Jordan Rupprecht via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
> >
> >
> > Author: Jordan Rupprecht
> > Date: 2020-08-03T18:37:50-07:00
> > New Revision: a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9
> >
> > URL:
> https://github.com/llvm/llvm-project/commit/a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9
> > DIFF:
> https://github.com/llvm/llvm-project/commit/a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9.diff
> >
> > LOG: Temporarily revert "[test] Exit with an error if no tests are run."
> >
> > This reverts commit adb5c23f8c0d60eeec41dcbe21d1b26184e1c97d. It
> surprisingly fails on a windows build bot:
> http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18009
> >
> > Will reland after some investigation and/or after adding some extra
> logging to help debug the issue.
> >
> > Added:
> >
> >
> > Modified:
> >    lldb/packages/Python/lldbsuite/test/dotest.py
> >
> > Removed:
> >
> >
> >
> >
> ################################################################################
> > diff  --git a/lldb/packages/Python/lldbsuite/test/dotest.py
> b/lldb/packages/Python/lldbsuite/test/dotest.py
> > index 6607f52c49db..3fb802f1c1aa 100644
> > --- a/lldb/packages/Python/lldbsuite/test/dotest.py
> > +++ b/lldb/packages/Python/lldbsuite/test/dotest.py
> > @@ -1039,10 +1039,6 @@ def run_suite():
> >             (configuration.suite.countTestCases(),
> >              configuration.suite.countTestCases() != 1 and "s" or ""))
> >
> > -    if configuration.suite.countTestCases() == 0:
> > -        logging.error("did not discover any matching tests")
> > -        exitTestSuite(1)
> > -
> >     # Invoke the test runner.
> >     if configuration.count == 1:
> >         result = unittest2.TextTestRunner(
> >
> >
> >
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200804/1fdb4b95/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3856 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200804/1fdb4b95/attachment.bin>