<div dir="ltr">Thanks, that explains it! Namely this part:<div><br><div>if sys.platform.startswith('win32'):</div><div>    # <a href="http://llvm.org/pr22274">llvm.org/pr22274</a>: need a pexpect replacement for windows<br>    class PExpectTest(object):<br>        pass</div>else:<br>    import pexpect<br>    class PExpectTest(TestBase):</div><div><br></div><div>For this change to reland, I'll need to make it always inherit from TestBase, but suppressed in some other way (maybe seeing if decorators like @skipIfWindows can be applied to whole test classes)<br><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 3, 2020 at 11:40 PM Raphael “Teemperor” Isemann <<a href="mailto:teemperor@gmail.com">teemperor@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">If it helps, all the failing tests are pexpect tests which are always disabled on Windows (like, they don't even exist from the test runners POV I believe). So I guess that's accidentially triggering that error.<br>
<br>
- Raphael<br>
<br>
> On 4 Aug 2020, at 03:39, Jordan Rupprecht via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
> <br>
> <br>
> Author: Jordan Rupprecht<br>
> Date: 2020-08-03T18:37:50-07:00<br>
> New Revision: a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9<br>
> <br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9.diff</a><br>
> <br>
> LOG: Temporarily revert "[test] Exit with an error if no tests are run."<br>
> <br>
> This reverts commit adb5c23f8c0d60eeec41dcbe21d1b26184e1c97d. It surprisingly fails on a windows build bot: <a href="http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18009" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18009</a><br>
> <br>
> Will reland after some investigation and/or after adding some extra logging to help debug the issue.<br>
> <br>
> Added: <br>
> <br>
> <br>
> Modified: <br>
>    lldb/packages/Python/lldbsuite/test/dotest.py<br>
> <br>
> Removed: <br>
> <br>
> <br>
> <br>
> ################################################################################<br>
> diff  --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py<br>
> index 6607f52c49db..3fb802f1c1aa 100644<br>
> --- a/lldb/packages/Python/lldbsuite/test/dotest.py<br>
> +++ b/lldb/packages/Python/lldbsuite/test/dotest.py<br>
> @@ -1039,10 +1039,6 @@ def run_suite():<br>
>             (configuration.suite.countTestCases(),<br>
>              configuration.suite.countTestCases() != 1 and "s" or ""))<br>
> <br>
> -    if configuration.suite.countTestCases() == 0:<br>
> -        logging.error("did not discover any matching tests")<br>
> -        exitTestSuite(1)<br>
> -<br>
>     # Invoke the test runner.<br>
>     if configuration.count == 1:<br>
>         result = unittest2.TextTestRunner(<br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
<br>
</blockquote></div>