[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 10 23:00:23 PDT 2020


shafik added inline comments.


================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:996
       m_clang_ast_context->GetUniqueNamespaceDeclaration(
-          g_lldb_local_vars_namespace_cstr, nullptr);
+          g_lldb_local_vars_namespace_cstr, nullptr, 0);
   if (!namespace_decl)
----------------
We are passing around `0` everywhere and it is not obvious what it means at all.

Can we name this somehow or make it a type?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75626/new/

https://reviews.llvm.org/D75626





More information about the lldb-commits mailing list