[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 10 16:59:17 PDT 2020


shafik added inline comments.


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:73
+  unsigned GetOwningModuleID() { return Flags(m_payload).Clear(ObjCClassBit); }
+  void SetOwningModuleID(unsigned id) {
+    assert(id < ObjCClassBit);
----------------
Why not use `uint32_t` like we did above? If we are going to assume `32 bits` we should just use the fixed width type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75626/new/

https://reviews.llvm.org/D75626





More information about the lldb-commits mailing list