[Lldb-commits] [EXTERNAL] [lldb] 42c906b - [lldb/API] Fix non null-terminated stop-reason in SBThread::GetStopDescription

[Mohamed Ismail Bennani via lldb-commits]

Hi,

> On 6 Feb 2020, at 00:32, Pavel Labath <labath at google.com> wrote:
> 
> 
> 
> On Wed, 5 Feb 2020 at 15:26, Stella Stamenova via lldb-commits <lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>> wrote:
> Does this fix the Windows failures that were reported this morning as well?
> 
> 
> I doubt that. In fact, I'm pretty sure it does not even fix the asan failure, but I cannot currently prove that because the build is broken in a couple of other ways too. As Fred pointed out already, you'll need to ensure that the temporary std::string does not get destroyed.
> 
> Also btw, string.c_str() will never be null, so there's no point in checking that.  

I was investigating the failures on Windows and Linux but I’ll need some more time.

I think Pavel already reverted my patches.

Sorry for the inconvenience.

Ismail.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200206/75db1e41/attachment.html>