<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 6 Feb 2020, at 00:32, Pavel Labath <<a href="mailto:labath@google.com" class="">labath@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 5 Feb 2020 at 15:26, Stella Stamenova via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Does this fix the Windows failures that were reported this morning as well?<br class="">
<br class=""></blockquote><div class=""><br class=""></div><div class="">I doubt that. In fact, I'm pretty sure it does not even fix the asan failure, but I cannot currently prove that because the build is broken in a couple of other ways too. As Fred pointed out already, you'll need to ensure that the temporary std::string does not get destroyed.</div><div class=""><br class=""></div><div class="">Also btw, string.c_str() will never be null, so there's no point in checking that. </div></div></div>
</div></blockquote></div><br class=""></div><div class="">I was investigating the failures on Windows and Linux but I’ll need some more time.</div><div class=""><br class=""></div><div class="">I think Pavel already reverted my patches.</div><div class=""><br class=""></div><div class="">Sorry for the inconvenience.</div><div class=""><br class=""></div><div class="">Ismail.</div></body></html>