[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:33
+    set(maybe_required)
+  elseif("${${variable}}" STREQUAL "ON")
+    set(maybe_required REQUIRED)
----------------
mgorny wrote:
> Now you broke it the other way around. Is there any reason you can't just `${${variable}}` here?
Can you please describe the desired behavior rather than the symptom? I must be missing what you're trying to achieve. :-) 

Maybe there's a gap in my CMake knowledge, but wouldn't `if(${${variable}})` evaluate to `true` for **any** string value? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71306/new/

https://reviews.llvm.org/D71306