[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 18 12:14:53 PST 2019


mgorny added inline comments.


================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:33
+    set(maybe_required)
+  elseif("${${variable}}" STREQUAL "ON")
+    set(maybe_required REQUIRED)
----------------
Now you broke it the other way around. Is there any reason you can't just `${${variable}}` here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71306/new/

https://reviews.llvm.org/D71306





More information about the lldb-commits mailing list