[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil accepted this revision.
jankratochvil added inline comments.
This revision is now accepted and ready to land.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:71
+            is_legacy_mode=False,
+            depends_on_projects=["llvm", "clang", "lldb", "lld"])
 
----------------
labath wrote:
> sivachandra wrote:
> > jankratochvil wrote:
> > > sivachandra wrote:
> > > > labath wrote:
> > > > > sivachandra wrote:
> > > > > > sivachandra wrote:
> > > > > > > I wonder why it is getting git.lab.llvm.org! Can you try with an additional arg to the LLVMBuildFactory constructor:
> > > > > > > 
> > > > > > > ```
> > > > > > >   repourl_prefix="http://github.com/llvm/"
> > > > > > > ```
> > > > > > May be https instead of http.
> > > > > Are you sure that's needed? I don't see anyone else setting that. @jankratochvil, could this be something specific to your setup?
> > > > If I am reading the code right, it should not be needed. I suggested that to see if @jankratochvil can make progress, which validates the rest of this patch.
> > > It is still at: https://github.com/llvm/llvm-zorg/blob/master/buildbot/osuosl/master/master.cfg#L59
> > > When I delete local `/home/buildbot/zorg-git/buildbot/osuosl/master/gitpoller-workdir` it will get rebuilt and it errors again:
> > > ```
> > > 2019-10-24 12:34:33+0200 [-] adding 3 new changesources, removing 0
> > > 2019-10-24 12:34:33+0200 [-] LLVMGitPoller: using workdir '/quad/home/buildbot/zorg-git/buildbot/osuosl/master/gitpoller-workdir'
> > > 2019-10-24 12:34:33+0200 [-] LLVMGitPoller: initializing working dir from http://git.lab.llvm.org/llvm/llvm-project.git
> > > 2019-10-24 12:34:33+0200 [-] configuration update complete
> > > 2019-10-24 12:34:33+0200 [-] while initializing LLVMGitPoller repository
> > >         Traceback (most recent call last):
> > >           File "/usr/lib64/python2.7/site-packages/twisted/internet/_baseprocess.py", line 64, in maybeCallProcessEnded
> > >             proto.processEnded(Failure(reason))
> > >           File "/usr/lib64/python2.7/site-packages/twisted/internet/utils.py", line 163, in processEnded
> > >             self.deferred.callback((out, err, code))
> > >           File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 460, in callback
> > >             self._startRunCallbacks(result)
> > >           File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 568, in _startRunCallbacks
> > >             self._runCallbacks()
> > >         --- <exception caught here> ---
> > >           File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
> > >             current.result = callback(current.result, *args, **kw)
> > >           File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/changes/llvmgitpoller.py", line 419, in _convert_nonzero_to_failure
> > >             raise EnvironmentError('command failed with exit code %d: %s' % (code, stderr))
> > >         exceptions.EnvironmentError: command failed with exit code 128: fatal: unable to access 'http://git.lab.llvm.org/llvm/llvm-project.git/': Could not resolve host: git.lab.llvm.org
> > > ```
> > > 
> > Ah, sorry! I missed that you were showing the master stack trace.
> > 
> > I wonder if its a repo which only the master can see. Look at this: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/32069
> > 
> > It seems to indicate that the master is tracking the git.lab.llvm repo, but "Checkout the source code" step is fetching from github.
> I'm afraid I am starting to get a bit lost here. Have we reached some kind of a conclusion? Should we maybe just commit it and see what happens? The bots are broken now anyway...
I agree your current patch should be an improvement of the current situation. I have no idea what is that `LLVMGitPoller` but it seems to be already broken and it is probably not required for the buildbots IIUC.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69341/new/

https://reviews.llvm.org/D69341