[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

[Pavel Labath via Phabricator via lldb-commits]

labath marked 5 inline comments as done.
labath added inline comments.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:71
+            is_legacy_mode=False,
+            depends_on_projects=["llvm", "clang", "lldb", "lld"])
 
----------------
sivachandra wrote:
> jankratochvil wrote:
> > sivachandra wrote:
> > > labath wrote:
> > > > sivachandra wrote:
> > > > > sivachandra wrote:
> > > > > > I wonder why it is getting git.lab.llvm.org! Can you try with an additional arg to the LLVMBuildFactory constructor:
> > > > > > 
> > > > > > ```
> > > > > >   repourl_prefix="http://github.com/llvm/"
> > > > > > ```
> > > > > May be https instead of http.
> > > > Are you sure that's needed? I don't see anyone else setting that. @jankratochvil, could this be something specific to your setup?
> > > If I am reading the code right, it should not be needed. I suggested that to see if @jankratochvil can make progress, which validates the rest of this patch.
> > It is still at: https://github.com/llvm/llvm-zorg/blob/master/buildbot/osuosl/master/master.cfg#L59
> > When I delete local `/home/buildbot/zorg-git/buildbot/osuosl/master/gitpoller-workdir` it will get rebuilt and it errors again:
> > ```
> > 2019-10-24 12:34:33+0200 [-] adding 3 new changesources, removing 0
> > 2019-10-24 12:34:33+0200 [-] LLVMGitPoller: using workdir '/quad/home/buildbot/zorg-git/buildbot/osuosl/master/gitpoller-workdir'
> > 2019-10-24 12:34:33+0200 [-] LLVMGitPoller: initializing working dir from http://git.lab.llvm.org/llvm/llvm-project.git
> > 2019-10-24 12:34:33+0200 [-] configuration update complete
> > 2019-10-24 12:34:33+0200 [-] while initializing LLVMGitPoller repository
> >         Traceback (most recent call last):
> >           File "/usr/lib64/python2.7/site-packages/twisted/internet/_baseprocess.py", line 64, in maybeCallProcessEnded
> >             proto.processEnded(Failure(reason))
> >           File "/usr/lib64/python2.7/site-packages/twisted/internet/utils.py", line 163, in processEnded
> >             self.deferred.callback((out, err, code))
> >           File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 460, in callback
> >             self._startRunCallbacks(result)
> >           File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 568, in _startRunCallbacks
> >             self._runCallbacks()
> >         --- <exception caught here> ---
> >           File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
> >             current.result = callback(current.result, *args, **kw)
> >           File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/changes/llvmgitpoller.py", line 419, in _convert_nonzero_to_failure
> >             raise EnvironmentError('command failed with exit code %d: %s' % (code, stderr))
> >         exceptions.EnvironmentError: command failed with exit code 128: fatal: unable to access 'http://git.lab.llvm.org/llvm/llvm-project.git/': Could not resolve host: git.lab.llvm.org
> > ```
> > 
> Ah, sorry! I missed that you were showing the master stack trace.
> 
> I wonder if its a repo which only the master can see. Look at this: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/32069
> 
> It seems to indicate that the master is tracking the git.lab.llvm repo, but "Checkout the source code" step is fetching from github.
I'm afraid I am starting to get a bit lost here. Have we reached some kind of a conclusion? Should we maybe just commit it and see what happens? The bots are broken now anyway...


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:110
     cmake_cmd = [
-        "cmake", "-G", "Ninja", "../llvm",
+        "cmake", "-G", "Ninja", "../" + self.monorepo_dir,
         "-DCMAKE_BUILD_TYPE=" + config,
----------------
sivachandra wrote:
> labath wrote:
> > jankratochvil wrote:
> > > sivachandra wrote:
> > > > Should this be os.path.join(os.pardir, f.monorepo_dir, "llvm") ?
> > > I was curious there is no longer trailing `"llvm"` as I am using `cmake ../llvm-monorepo/llvm/`.  Yes, it does compile with the new expression there:
> > > ```
> > >         "cmake", "-G", "Ninja", os.path.join(os.pardir, f.monorepo_dir, "llvm"),
> > > ```
> > Technically, using `os.path.join`, is not correct here, because this is a path on the buildbot, not the path on the host which runs the master. In practice that doesn't matter because the master runs on a posix system. The existing code is pretty inconsistent about the usage, but the `../` seems to be a bit more common.
> Right. The main point I was trying to convey was to add the path to the llvm directory.
> 
> I am only interested in seeing what you eventually land as I want to use the same for the LLVM libc builders.
Got it. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69341/new/

https://reviews.llvm.org/D69341