[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D66429#1636655 <https://reviews.llvm.org/D66429#1636655>, @labath wrote:

> That said, I'm not a fan of force-overwriting cache variables specified by the user, particularly when the same effect can be achieved by *deleting* the cache variable instead of setting it to an empty string. I think you should be able to reset the default value of `LLDB_TEST_C_COMPILER` (just like any other cmake variable) by running `cmake -ULLDB_TEST_C_COMPILER`. You can even delete both variables at once with `-ULLDB_TEST_*_COMPILER`.


Sounds good to me, I'll update the patch. The only reason I did it this way is because I wasn't sure everyone knew about this functionality.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66429/new/

https://reviews.llvm.org/D66429