[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 20 10:40:36 PDT 2019


stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

I think this is actually fine. The change that was needed for multi-configuration generators is how the two default paths for the compilers are set. The USE variables were to make it explicit when we will or we won't override the user-set compiler. As long as we are OK overriding it if they set it to an empty string (which is probably an error, anyway), this change is good.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66429/new/

https://reviews.llvm.org/D66429





More information about the lldb-commits mailing list