[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 19 16:42:10 PDT 2019


xiaobai marked an inline comment as done.
xiaobai added inline comments.


================
Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27
+    eAppleObjCDeclVendor,
+    eLastClangDeclVendor,
+  };
----------------
JDevlieghere wrote:
> What's `eLastClangDeclVendor` and where is it used?
Following the advice here: https://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html

I added a Last one to indicate that any new ClangDeclVendor subclasses should go before this one. It also makes the classof pattern of checking bounds easier. (kind >= eFoo && kind < eLastFoo).




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66451/new/

https://reviews.llvm.org/D66451





More information about the lldb-commits mailing list