[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27
+    eAppleObjCDeclVendor,
+    eLastClangDeclVendor,
+  };
----------------
What's `eLastClangDeclVendor` and where is it used?


================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h:33
+  static bool classof(const DeclVendor *vendor) {
+    return vendor->GetKind() >= eClangDeclVendor &&
+           vendor->GetKind() < eLastClangDeclVendor;
----------------
I think a switch would be more readable? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66451/new/

https://reviews.llvm.org/D66451