[Lldb-commits] [PATCH] D63594: [lldb] [Process/NetBSD] Simplify register buffer usage
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 20 04:47:38 PDT 2019
labath added a comment.
In D63594#1551715 <https://reviews.llvm.org/D63594#1551715>, @mgorny wrote:
> In D63594#1551702 <https://reviews.llvm.org/D63594#1551702>, @labath wrote:
> > BTW, is ReadGPR even called from some other place than `NativeRegisterContextNetBSD_x86_64::ReadRegisterSet` ? If not, then we could remove all of these functions (except the `ReadRegisterSet` I suggest above), and inline everything into `NativeRegisterContextNetBSD_x86_64::ReadRegisterSet` (one of these should be renamed, obviously), removing about 5 layers of indirection...
> I think the idea is that they will be reused when we introduce additional architectures.
How exactly would that work? If the other architectures follow the pattern of x86_64, then they will also have a `ReadRegisterSet` function, which can be used for reading everything. And doing things this way doesn't force every architecture to fit into predefined set of register sets.
This is your code, so that's ultimately up to you, but I'd try to aim for simplicity first, and if it later turns out to be useful to reintroduce these functions, then so be it...
CHANGES SINCE LAST ACTION
More information about the lldb-commits