[Lldb-commits] [PATCH] D63594: [lldb] [Process/NetBSD] Simplify register buffer usage
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 20 04:42:52 PDT 2019
mgorny added a comment.
In D63594#1551702 <https://reviews.llvm.org/D63594#1551702>, @labath wrote:
> BTW, is ReadGPR even called from some other place than `NativeRegisterContextNetBSD_x86_64::ReadRegisterSet` ? If not, then we could remove all of these functions (except the `ReadRegisterSet` I suggest above), and inline everything into `NativeRegisterContextNetBSD_x86_64::ReadRegisterSet` (one of these should be renamed, obviously), removing about 5 layers of indirection...
I think the idea is that they will be reused when we introduce additional architectures.
CHANGES SINCE LAST ACTION
More information about the lldb-commits