[Lldb-commits] [PATCH] D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D63339#1546091 <https://reviews.llvm.org/D63339#1546091>, @jankratochvil wrote:

> In D63339#1546076 <https://reviews.llvm.org/D63339#1546076>, @labath wrote:
>
> > It looks like lldb-mi has the `--source` option. Could that be used to set this setting automatically via lit, as it is done with `%lldb` ?
>
>
> The problem is it generates additional `^done` line
>
>   echo 'settings set symbols.enable-external-lookup false' >/tmp/1j;lldb-mi --source /tmp/1j
>   (gdb)
>   settings set symbols.enable-external-lookup false
>   ^done
>   (gdb)
>
>
>   which the scripts do not expect. They already expect such "unexpected" response from a commandline parameter the scripts pass themselves (`%t`):
>
>   # RUN: %lldbmi %t < %s | FileCheck %s
>   # Check that we have a valid target created via '%lldbmi %t'.
>   # CHECK: ^done
>
>
> This would mean adding additional one `# CHECK: ^done` for the `settings set symbols.enable-external-lookup false` command which is not present in the script which I hope you agree is worse than adding both that command+its response as I did.
>  Or did you mean it some different way? Thanks for the review.


Nope, that's exactly what I meant. I think the fact that you're not able to do this is a pretty big flaw in these lldb-mi tests, but I've already kind of given up on lldb-mi, so I don't care either way..

The rest of the changes seem fine to me.



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:736
         # init file unless told otherwise.
-        if "NO_LLDBINIT" in os.environ and "NO" == os.environ["NO_LLDBINIT"]:
-            self.lldbOption = ""
-        else:
-            self.lldbOption = "--no-lldbinit"
+        if "NO_LLDBINIT" not in os.environ or "NO" != os.environ["NO_LLDBINIT"]:
+            self.lldbOption += " --no-lldbinit"
----------------
```
if os.environ.get("NO_LLDBINIT") != "NO":
```


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63339/new/

https://reviews.llvm.org/D63339