[Lldb-commits] [PATCH] D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 17 07:06:02 PDT 2019
jankratochvil added a comment.
In D63339#1546076 <https://reviews.llvm.org/D63339#1546076>, @labath wrote:
> It looks like lldb-mi has the `--source` option. Could that be used to set this setting automatically via lit, as it is done with `%lldb` ?
The problem is it generates additional `^done` line
echo 'settings set symbols.enable-external-lookup false' >/tmp/1j;lldb-mi --source /tmp/1j
settings set symbols.enable-external-lookup false
which the scripts do not expect. They already expect such "unexpected" response from a commandline parameter the scripts pass themselves (`%t`):
# RUN: %lldbmi %t < %s | FileCheck %s
# Check that we have a valid target created via '%lldbmi %t'.
# CHECK: ^done
This would mean adding additional one `# CHECK: ^done` for the `settings set symbols.enable-external-lookup false` command which is not present in the script which I hope you agree is worse than adding both that command+its response as I did.
Or did you mean it some different way? Thanks for the review.
CHANGES SINCE LAST ACTION
More information about the lldb-commits