[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

Tue May 28 01:36:13 PDT 2019

labath requested changes to this revision.
labath added a reviewer: JDevlieghere.
labath added a subscriber: JDevlieghere.
labath added a comment.
This revision now requires changes to proceed.

Definitely go for the option of refactoring the DYLD AuxVector class to make it usable from lldb-server.

It doesn't look like it should be that complicated even. Instead of passing it a `Process` instance, we can just pass it the data we have obtained from the right process (liblldb process, or lldb-server process), along with any other data it needs to interpret it (looks like it's just the pointer size (?)).

The question of plugins depending on each other is just a matter of finding the right place to put this new class. In my mind, Plugins/Process/Utility` is not a real plugin, and I don't see much of a problem in the Posix dynamic loader depending on that (it makes sense that it would need *some* data about the process in order to do its job. Or, given that the new class will depend on just the data extractor and nothing else, we could put it all the way up to `Utility`.

A third option would be to create a completely new library for this. In the past we've talked about a new library for "classes describing various properties of a process", where we'd have MemoryRegionInfo, ProcessInfo, etc, but so far it hasn't materialized. It seems like this could fit nicely into this description, so we could start with the new library with this class. + at JDevlieghere for any thoughts on this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62500/new/

https://reviews.llvm.org/D62500