[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

[António Afonso via Phabricator via lldb-commits]

aadsm created this revision.
aadsm added reviewers: clayborg, xiaobai.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
aadsm added a parent revision: D62499: Create a generic handler for Xfer packets.
aadsm added a child revision: D62501: Implement GetSharedLibraryInfoAddress.

This is the second patch to improve module loading in a series that started here (where I explain the motivation and solution): https://reviews.llvm.org/D62499

I need to read the aux vector to know where the r_debug map with the loaded libraries are.
We already have a AuxVector class beloging to the POSIX-DYLD plugin but I didn't want to link that lib in. That class also depends on a Process instance which I don't have. I created a new ELFAuxVector that receives a DataExtractor so the data could be really coming from anywhere.
I'm not sure if this is the best way to do this, but I do think that a class that only depends on a DataExtractor makes sense. I can get rid of the AuxVector class and use the ELFAuxVector in the POSIX-DYLD (it's really only used in one place) but that also means that we'll have plugins depending on each other and I'm not sure if that's ok. That's the reason why I haven't done this yet.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62500

Files:
  lldb/include/lldb/Host/common/NativeProcessProtocol.h
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.h
  lldb/source/Plugins/Process/Utility/CMakeLists.txt
  lldb/source/Plugins/Process/Utility/ELFAuxVector.cpp
  lldb/source/Plugins/Process/Utility/ELFAuxVector.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62500.201588.patch
Type: text/x-patch
Size: 7528 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190527/62be249f/attachment.bin>