[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

Aaron Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 11 14:24:19 PDT 2019


asmith marked an inline comment as done.
asmith added inline comments.


================
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:188-192
+    g_print_mutex.lock();
     printf("thread %d id: ", this_thread_index);
     print_thread_id();
     printf("\n");
+    g_print_mutex.unlock();
----------------
labath wrote:
> use std::scoped_lock instead of manual lock/unlock calls (throughout the patch).
Is cxx17 now officially okay to use?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60496/new/

https://reviews.llvm.org/D60496





More information about the lldb-commits mailing list